FEAT: fmod ufunc implementation
#178
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copilot Summary
This pull request adds support for the
fmod(floating-point modulo) operation for quad-precision and long double types in the numpy quad dtype extension. It implements the correct mathematical behavior forfmod, including handling of edge cases, exposes the new ufunc to Python, documents the feature, and thoroughly tests it with a wide range of inputs and special properties.Implementation of fmod operation:
quad_fmodandld_fmodfunctions inops.hppto implement floating-point modulo for quad-precision and long double types, with correct handling of NaN, infinity, division by zero, sign preservation, and mathematical properties. [1] [2]Integration and exposure in Python:
fmodufunc ininit_quad_binary_opsso it is available asnp.fmodfor quad dtypes.Documentation:
release_tracker.mdto markfmodas implemented and tested for both quad and long double types.Testing:
fmodintest_quaddtype.py, covering a wide range of edge cases (NaN, infinities, zeros, sign preservation, and mathematical identities), as well as differences frommod/remainder.