FIX: Boolean casting comparison should be in real domain - #44
Merged
Conversation
Member
Author
|
@melissawm was there any env variable |
Member
Author
|
docs are successfully got hosted here https://numpy.org/numpy-quaddtype/ |
Member
|
I think if you want to have a docs preview in PRs you'll need to separately configure that. |
Member
|
Many doc build actions workflows skip the deploy step on PRs |
Member
Author
|
In that case please feel free to review the PRs and we can merge if they sound good. |
juntyr
approved these changes
Jan 17, 2026
juntyr
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for the fix!
Member
Author
|
Merging this fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #41
Find one more issue in scalar implementation as from cpython the signature of
quad_nonzerofunctuon should beand earlier we were returning a PyObject (which is bad as everything might turn up True). This is also fixed here