Skip to content

FIX: Boolean casting comparison should be in real domain - #44

Merged
SwayamInSync merged 2 commits into
numpy:mainfrom
SwayamInSync:bool-cast
Jan 19, 2026
Merged

FIX: Boolean casting comparison should be in real domain#44
SwayamInSync merged 2 commits into
numpy:mainfrom
SwayamInSync:bool-cast

Conversation

@SwayamInSync

Copy link
Copy Markdown
Member

closes #41
Find one more issue in scalar implementation as from cpython the signature of quad_nonzero functuon should be

typedef int (*inquiry)(PyObject *);

and earlier we were returning a PyObject (which is bad as everything might turn up True). This is also fixed here

@SwayamInSync

Copy link
Copy Markdown
Member Author

@melissawm was there any env variable ACTIONS_ID_TOKEN_REQUEST_URL for docs?

@SwayamInSync SwayamInSync changed the title Boolean casting comparison should be in real domain FIX: Boolean casting comparison should be in real domain Jan 16, 2026
@SwayamInSync

Copy link
Copy Markdown
Member Author

docs are successfully got hosted here https://numpy.org/numpy-quaddtype/
but in PR it is asking for some missing env variable

@ngoldbaum

Copy link
Copy Markdown
Member

I think if you want to have a docs preview in PRs you'll need to separately configure that.

@ngoldbaum

ngoldbaum commented Jan 16, 2026

Copy link
Copy Markdown
Member

Many doc build actions workflows skip the deploy step on PRs

@SwayamInSync

Copy link
Copy Markdown
Member Author

In that case please feel free to review the PRs and we can merge if they sound good.
I'll see how we can configure the action for PR separately

@juntyr juntyr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@SwayamInSync

Copy link
Copy Markdown
Member Author

Merging this fix

@SwayamInSync
SwayamInSync merged commit c9dca2b into numpy:main Jan 19, 2026
9 checks passed
@SwayamInSync
SwayamInSync deleted the bool-cast branch January 19, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QuadDtype -> bool cast is wrong

3 participants