Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer Updated: Improving the footer layout and ui (closes#201) #204 #207

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

devlohani99
Copy link

Screenshot 2025-02-19 191137

I guess now it should contain the changes
@aterrel

@aterrel
Copy link
Member

aterrel commented Feb 22, 2025

@devlohani99 looks like you forgot to check in the changes. I definitely recommend using git status and git add to see what is checking in and explicitly add in your files. If you like GUI's better, I have always liked SourceTree.

Copy link
Member

@aterrel aterrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check in files for footer. This patch only has the .gitignore file.

@aterrel aterrel added the 🔄 changes required need update before reviewing again label Feb 22, 2025
Copy link
Author

@devlohani99 devlohani99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aterrel, I am unsure if it is good practice to push the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔄 changes required need update before reviewing again
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants