fix: use new image metadata as destination when copying exif data #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@murat-mehmet can you checkout this use case in android? |
|
@murat-mehmet released in 1.8.22 |
android works well in this case 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently on iOS exif metadata is copied from the new file to the old file, this causes new orientation value to be ignored. The orientation from the old file causes image to be displayed incorrectly.
Solution is to actually copy from source to the new metadata and use the new one.
Changelog
fixed copy exif on iOS
Test Plan
Test compression of an image with rotated orientation.