Skip to content

Fix the issue where primal solver cannot be used in libmultilabel. #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhi-bao
Copy link
Contributor

@zhi-bao zhi-bao commented Mar 6, 2025

What does this PR do?

Because the weight recalculation technique only applies to the L1/L2-SVM dual solver in LIBLINEAR, LIBLINEAR prohibits use of the other solvers when the w_recalc flag is set. However, LibMultiLabel always sets the w_recalc flag despite using the other solvers. To fix this issue, the w_recalc flag is now set only when using L1/L2-SVM dual solver.

Test CLI & API (bash tests/autotest.sh)

Test APIs used by main.py.

  • Test Pass
    • (Copy and paste the last outputted line here.)
  • Not Applicable (i.e., the PR does not include API changes.)

Check API Document

If any new APIs are added, please check if the description of the APIs is added to API document.

  • API document is updated (linear, nn)
  • Not Applicable (i.e., the PR does not include API changes.)

Test quickstart & API (bash tests/docs/test_changed_document.sh)

If any APIs in quickstarts or tutorials are modified, please run this test to check if the current examples can run correctly after the modified APIs are released.

@zhi-bao zhi-bao requested review from cjlin1 and a team as code owners March 6, 2025 06:57
@Eleven1Liu Eleven1Liu added model/linear bug Something isn't working labels Mar 7, 2025
@Eleven1Liu
Copy link
Contributor

Eleven1Liu commented Mar 7, 2025

@zhi-bao Please also bump the version to 0.7.3 (https://github.com/ntumlgroup/LibMultiLabel/blob/master/setup.cfg#L3) for release. Thanks.

@Eleven1Liu Eleven1Liu added the release PyPI release tag is in this PR label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working model/linear release PyPI release tag is in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants