-
Notifications
You must be signed in to change notification settings - Fork 8
Update inference method involving prune tree prediction. #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zhi-bao
wants to merge
15
commits into
ntumlgroup:master
Choose a base branch
from
zhi-bao:prune_inference
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+99
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please also add the acceleration time (before/after this PR) in the description box after it is finished. Thanks! |
Please also remember to run black formatter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR does the following two things:
Reimplements the inference method in LibMultiLabel. In the inference method of LibMultiLabel, the algorithm performs a single matrix multiplication between the batch instances and a weight matrix containing all classifiers. However, when the beam width is smaller than the root's degree, unnecessary computations occur on root child nodes that are unreachable. To address this, we reimplement the method by pruning those unreachable child nodes during computation with the given batch instances, improving efficiency.
Modifies the structure of the Tree Model based on the new implementation. In the tree model structure of LibMultiLabel, all nodes' classifiers needed to be flattened into a single weight matrix. LibMultiLabel uses hstack to flatten weights, which requires twice the memory due to duplication. However, in the new implementation, we only need to flatten the weights in the root's subtree, which requires less memory than flattening all nodes' classifiers, thereby reducing overall memory usage.
Test CLI & API (
bash tests/autotest.sh
)Test APIs used by main.py.
Check API Document
If any new APIs are added, please check if the description of the APIs is added to API document.
Test quickstart & API (
bash tests/docs/test_changed_document.sh
)If any APIs in quickstarts or tutorials are modified, please run this test to check if the current examples can run correctly after the modified APIs are released.