Skip to content

Recency Bias#15

Open
michaelmcd18 wants to merge 6 commits intontbloom:mainfrom
michaelmcd18:recent-play
Open

Recency Bias#15
michaelmcd18 wants to merge 6 commits intontbloom:mainfrom
michaelmcd18:recent-play

Conversation

@michaelmcd18
Copy link
Collaborator

No description provided.

@michaelmcd18
Copy link
Collaborator Author

Noticed that evanmiya had some extra columns when you select "Show Change - Last 30 Days"

They provide each team's change in BPR over the last 30 days, which teams who have increased the most could have more momentum than team's with a higher BPR, but worse play over the last 30 days.

Added strategy is "RecencyBias", which follows TheCuts pretty closely

@seth127 seth127 self-requested a review March 16, 2023 12:58
@seth127
Copy link
Collaborator

seth127 commented Mar 16, 2023

@ntbloom I'll take a look at this, probably this weekend. I talked to @michaelmcd18 and we'll probably refactor how he loads this recency data a bit. That said, I'm very psyched to have recency data in here.

He has it running though, so he can print himself a bracket if he wants to. There's no need to actually merge this before the tourney starts.

RecencyBias considers:
- Roster Rank (percentile)
- Season BPR
- Kill shots per game / Kill shots allowed per game ratio
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm, this is a good thought. I don't think anyone has done this as a ratio yet.

Copy link
Owner

@ntbloom ntbloom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the recency bias idea and think this should just be part of the main EvanMiya hierarchy.

@seth12 can you work with Michael on a refactor so that there is only a single IEvanMiya class and a single evanmiya data file but the 30-day changes are included as attributes?

@michaelmcd18 I'm adding you as a contributor so you can work directly in the repo instead of having to fork.

Great stuff all around! I have another refactor in the works to get better type safety around EvanMiya data generally speaking, but I'll wait until this MR is merged. Let me know if you need any help in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants