Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add invocations to applicationlog #3569

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
+304 −21
Open

*: add invocations to applicationlog #3569

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d8a0d13
Store invocations in application log
ixje Jun 28, 2024
04c71f5
rename params to arguments
ixje Sep 2, 2024
dfd5c9b
make invocation saving configurable, safely handle args
ixje Oct 31, 2024
cd7caf5
re-use serialized arguments for storing
ixje Oct 31, 2024
e7063a2
feedback
ixje Nov 20, 2024
ae3b481
process feedback
ixje Jan 2, 2025
bc4cb3d
process feedback
ixje Jan 22, 2025
5ffb57d
add better RPC example
ixje Jan 22, 2025
90c18b7
preserve argBytes
ixje Jan 22, 2025
d1d0921
use VMState as marker
ixje Jan 22, 2025
25e93ec
process feedback
ixje Jan 22, 2025
72caf56
move code around
ixje Jan 23, 2025
4876e70
document bit masks consts
ixje Jan 23, 2025
036e6cb
update encode/decode binary routines, merge binary tests
ixje Jan 23, 2025
7b83ff3
update marshal/unmarshal routines, merge marshalling tests
ixje Jan 23, 2025
fa29376
simplify NewContractInvocation
ixje Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/core/interop/contract/call.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@ func Call(ic *interop.Context) error {
arr := stackitem.NewArray(args)
ixje marked this conversation as resolved.
Show resolved Hide resolved
arrCount := len(args)
valid := true
if _, err = ic.DAO.GetItemCtx().Serialize(arr, false); err != nil {
argBytes := []byte{}
ixje marked this conversation as resolved.
Show resolved Hide resolved
if argBytes, err = ic.DAO.GetItemCtx().Serialize(arr, false); err != nil {
arr = stackitem.NewArray([]stackitem.Item{})
valid = false
}
Expand All @@ -83,6 +84,7 @@ func Call(ic *interop.Context) error {
Hash: u,
Method: method,
Arguments: arr,
ArgumentsBytes: argBytes,
ArgumentsCount: uint32(arrCount),
IsValid: valid,
})
Expand Down
20 changes: 6 additions & 14 deletions pkg/core/state/notification_event.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,36 +24,28 @@ type ContractInvocation struct {
Hash util.Uint160 `json:"contract_hash"`
Method string `json:"method"`
Arguments *stackitem.Array `json:"arguments"`
ArgumentsBytes []byte `json:"arguments_bytes"`
AnnaShaleva marked this conversation as resolved.
Show resolved Hide resolved
ArgumentsCount uint32 `json:"arguments_count"`
ixje marked this conversation as resolved.
Show resolved Hide resolved
IsValid bool `json:"is_valid"`
ixje marked this conversation as resolved.
Show resolved Hide resolved
}

func (ci *ContractInvocation) DecodeBinary(r *io.BinReader) {
ci.Hash.DecodeBinary(r)
ci.Method = r.ReadString()
args := stackitem.DecodeBinary(r)
if r.Err != nil {
return
}
arr, ok := args.Value().([]stackitem.Item)
if !ok {
r.Err = errors.New("array or Struct expected")
ci.ArgumentsBytes = r.ReadVarBytes()
si, err := stackitem.Deserialize(ci.ArgumentsBytes)
if err != nil {
return
}
ci.Arguments = stackitem.NewArray(arr)
ci.Arguments = si.(*stackitem.Array)
ci.ArgumentsCount = r.ReadU32LE()
ci.IsValid = r.ReadBool()
}

func (ci *ContractInvocation) EncodeBinaryWithContext(w *io.BinWriter, sc *stackitem.SerializationContext) {
ci.Hash.EncodeBinary(w)
w.WriteString(ci.Method)
b, err := sc.Serialize(ci.Arguments, false)
if err != nil {
w.Err = err
return
}
w.WriteBytes(b)
w.WriteVarBytes(ci.ArgumentsBytes)
w.WriteU32LE(ci.ArgumentsCount)
w.WriteBool(ci.IsValid)
}
Expand Down