Skip to content

Conversation

betolink
Copy link
Member

@betolink betolink commented May 28, 2025

This is a weird case of colliding PRs, this work started at the hacking hour today and lo and behold, @kgrimes2 opened basically the same PR 2 hours ago! #1020

This draft PR doesn't have an interactive mode for the token only strategy, which may be handy. We need to improve the documentation and modify the EDL notebook to show the different authorization workflows.

cc @jhkennedy @danielfromearth @ateucher @asteiker @andypbarrett

Pull Request (PR) draft checklist - click to expand
  • Please review our
    contributing documentation
    before getting started.
  • Populate a descriptive title. For example, instead of "Updated README.md", use a
    title such as "Add testing details to the contributor section of the README".
    Example PRs: #763
  • Populate the body of the pull request with:
  • Update CHANGELOG.md with details about your change in a section titled
    ## Unreleased. If such a section does not exist, please create one. Follow
    Common Changelog for your additions.
    Example PRs: #763
  • Update the documentation and/or the README.md with details of changes to the
    earthaccess interface, if any. Consider new environment variables, function names,
    decorators, etc.

Click the "Ready for review" button at the bottom of the "Conversation" tab in GitHub
once these requirements are fulfilled. Don't worry if you see any test failures in
GitHub at this point!

Pull Request (PR) merge checklist - click to expand

Please do your best to complete these requirements! If you need help with any of these
requirements, you can ping the @nsidc/earthaccess-support team in a comment and we
will help you out!

  • Add unit tests for any new features.
  • Apply formatting and linting autofixes. You can add a GitHub comment in this Pull
    Request containing "pre-commit.ci autofix" to automate this.
  • Ensure all automated PR checks (seen at the bottom of the "conversation" tab) pass.
  • Get at least one approving review.

📚 Documentation preview 📚: https://earthaccess--1021.org.readthedocs.build/en/1021/

Copy link

github-actions bot commented May 28, 2025

Binder 👈 Launch a binder notebook on this branch for commit ab85df5

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 519fba2

@chuckwondo
Copy link
Collaborator

@betolink, I think we can close this now that #1020 landed, correct?

@betolink
Copy link
Member Author

@chuckwondo I think so, this PR has some unit tests that we could use for the token but let's close it.

@betolink
Copy link
Member Author

closing this in favor of #1020

@betolink betolink closed this Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants