-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup(misc): migrate from chalk to picocolors #27967
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7300501. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
This change should really be I've updated it to be |
Makes sense to me 👍 Wasn't sure what the correct scope and type of change was. Thanks for the tip Will resolve the comments soon |
e9c0f0c
to
f74fd81
Compare
I'm struggling to understand the current failure any chance you could help me out? 👀 I think its a failing test but I cant seem to find where in the circleci output we can get hold of which test |
Migrates from `chalk` to the much smaller and faster `picocolors`.
f74fd81
to
7300501
Compare
Migrates from
chalk
to the much smaller and fasterpicocolors
.Part of a wider ecosystem cleanup, we are moving many projects over to picocolors or node's native styleText.
If you let me know you're happy with this change, I'll push a branch for each of the other packages to do the same.
I will catch up from master when I'm back on my laptop 👍