Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storybook): remove cypress options for e2e testing #27850

Merged
merged 10 commits into from
Sep 24, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Sep 10, 2024

  • feat(storybook): remove cypress options from configuration generator
  • feat(react): remove cypress options from storybook-configuration
  • feat(react): remove cypress options from stories generator
  • feat(react): remove component-cypress-spec generator
  • chore(storybook): restore @nx/cypress dep
  • feat(remix): remove cypress options from storybook
  • feat(angular): remove cypress options from storybook-configuration
  • feat(angular): remove cypress options from stories generator
  • feat(angular): remove component-cypress-spec generator
  • feat(vue): remove cypress options from stories generator

Current Behavior

With Storybook Interaction Testing, there's no longer a need to setup Cypress to specifically test storybook instances

Expected Behavior

Remove cypress options for creating an e2e project specifically for testing storybook instances.

Use Storybook Interaction Testing instead

Related Issue(s)

Fixes #

@Coly010 Coly010 self-assigned this Sep 10, 2024
Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Sep 23, 2024 2:29pm

@Coly010 Coly010 added the target: next major version To be merged for the next major version release label Sep 10, 2024
@Coly010 Coly010 merged commit 8290969 into master Sep 24, 2024
6 checks passed
@Coly010 Coly010 deleted the storybook/remove-cypress branch September 24, 2024 14:55
Copy link

github-actions bot commented Oct 1, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants