feat(core): add fallback cache for db cache #27841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
AgentEnder
commented
Sep 11, 2024
Comment on lines
78
to
85
| const error = [ | ||
| `Invalid Cache Directory for Task "${task.id}"`, | ||
| `The local cache artifact in "${cacheDir}" was found in ${cacheDir}.`, | ||
| `When using the database cache, cache artifacts are stored in a database within ${workspaceDataDirectory}.`, | ||
| ``, | ||
| `If you believe this is a mistake, running \`nx reset\` will clear the cache and allow it to be repopulated.`, | ||
| `Alternatively, setting NX_REJECT_UNKNOWN_LOCAL_CACHE to false will bypass this check.`, | ||
| ``, |
There was a problem hiding this comment.
@FrozenPandaz this is the spot we should tune the error message a bit.
AgentEnder
force-pushed
the
feat/shared-local-db
branch
from
7f0b5c6
to
cf8abda
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 221e713. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
feat/shared-local-db
branch
5 times, most recently
from
1c9f6ca
to
09b66a4
Compare
FrozenPandaz
requested changes
Sep 16, 2024
packages/nx/src/native/db/mod.rs
Outdated
| "{}.db", | ||
| match db_name { | ||
| Some(name) => name, | ||
| None => machine_id, |
There was a problem hiding this comment.
Call the get_machine_id() in here
packages/nx/src/native/db/mod.rs
Outdated
| let db_path = cache_dir_buf.join(format!("{}.db", machine_id)); | ||
| let db_path = cache_dir_buf.join(format!( | ||
| "{}.db", | ||
| match db_name { |
There was a problem hiding this comment.
this can be more idiomatic
db_name.unwrap_or_else(|| get_machine_id())| if (cacheDir !== defaultCacheDir) { | ||
| this.fallbackDbCache = new NxCache( | ||
| workspaceRoot, | ||
| process.env.NX_SHARED_CACHE_DIRECTORY, |
There was a problem hiding this comment.
This should be cacheDir
| // hit issues. If we detect this, we can create a fallback db cache in the | ||
| // custom directory, and check if the entries are there when the main db | ||
| // cache misses. | ||
| if (cacheDir !== defaultCacheDir) { |
There was a problem hiding this comment.
We should implement some kind of "cache reflects fs state"
FrozenPandaz
added
the
PR status: do not merge
FrozenPandaz
force-pushed
the
feat/shared-local-db
branch
from
995d6ac
to
221e713
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #