Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Segments in blueprint contexts #1393

Open
wants to merge 2 commits into
base: release53
Choose a base branch
from

Conversation

mint-dewit
Copy link
Contributor

About the Contributor

This pull request is posted on behalf of the BBC.

Type of Contribution

This is a: Enhancement

Current Behavior

  • Blueprints can set public and private data on segments but have no way to read this information back

New Behavior

  • Blueprints can use the getSegment method on the Action/ OnSetAsNext / OnTake contexts

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

This PR affects the blueprint contexts

Time Frame

Not urgent, but we would like to get this merged into the in-development release.

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@mint-dewit mint-dewit requested a review from a team as a code owner February 27, 2025 16:35
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 70.83333% with 7 lines in your changes missing coverage. Please review.

Please upload report for BASE (release53@955d96e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...text/services/PartAndPieceInstanceActionService.ts 30.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             release53    #1393   +/-   ##
============================================
  Coverage             ?   56.27%           
============================================
  Files                ?      408           
  Lines                ?    73118           
  Branches             ?     4189           
============================================
  Hits                 ?    41148           
  Misses               ?    31843           
  Partials             ?      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant