chore: add check to install-and-build script to disallow yarn 1 #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because if one has a system that has yarn 1 / yarn classic installed, some weird errors pop up during instllatoin and build. This script will catch the issue early and provice a user friendlier feedback
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release53 #1391 +/- ##
============================================
Coverage ? 56.27%
============================================
Files ? 408
Lines ? 73094
Branches ? 4217
============================================
Hits ? 41136
Misses ? 31867
Partials ? 91 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the NRK.
Type of Contribution
This is a: Code improvement
Current Behavior
If I have yarn 1 / yarn classic installed on my system, I get some errors such as
'run' not a executable commandand the like, which are hard to troubleshoot for a new developer.New Behavior
When running install-and-build, the script will catch the issue early and provide a user friendlier feedback.
Status