Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Hover Previews #1390

Draft
wants to merge 21 commits into
base: release53
Choose a base branch
from

Conversation

mint-dewit
Copy link
Contributor

About the Contributor

This pull request is posted on behalf of the BBC.

Type of Contribution

This is a: Feature

Current Behavior

  • The design for hover previews is many years old and not been revised
  • Any piece can only show a hover preview for the type of source layer that it is on

New Behavior

  • Update design for better consistency
  • Allow blueprints to override the hover preview for any piece (i.e. detach the hover preview from source layer type)
  • Hover previews can be opened from anywhere that has the context available
  • Previews have the option to either track the mouse or be displayed in a static position

Affected areas

This PR only affects the frontend code. (Except for some additional types in blueprints integration)

Time Frame

Other Information

  • Some files for development (HTML pages and video file) as well as an option to point all VT hover previews to aforementioned video file have been included
  • This PR has been based on initial work from NRK but I have not added any of the interactive elements, leaving that up to NRK to implement

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 19.35484% with 25 lines in your changes missing coverage. Please review.

Please upload report for BASE (release53@955d96e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ns/pieceContentStatusUI/checkPieceContentStatus.ts 9.52% 19 Missing ⚠️
packages/corelib/src/lib.ts 20.00% 4 Missing ⚠️
meteor/server/api/rest/v1/typeConversion.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             release53    #1390   +/-   ##
============================================
  Coverage             ?   56.24%           
============================================
  Files                ?      408           
  Lines                ?    73122           
  Branches             ?     4600           
============================================
  Hits                 ?    41129           
  Misses               ?    31739           
  Partials             ?      254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants