fix: omit privateData in bucket adlib pieces and actions publications

[ianshade]

About the Contributor

This pull request is posted on behalf of TV 2 Norge

Type of Contribution

This is a:

Bug fix

Current Behavior

Bucket AdLib Pieces' and Bucket AdLib Actions' privateData is exposed to the frontend via publications.
There are no defined constraints regarding what can be placed in privateData of Bucket AdLib Pieces and Bucket AdLib Actions, however if any (sub)property within it starts with a $, minimongo will throw on the frontend, and some parts of the UI will refuse to render (likely just the contents of the bucket). It's a common practice [citation needed] to store entire Pieces generated ahead of time, including their timeline objects (which oftentimes contain a $references property), in privateData of AdLib Actions, therefore this bug is likely to occur for anyone who does that in their blueprints. Besides that, it may also have some performance impact, depending on the size of privateData.

New Behavior

Bucket AdLib Pieces' and Bucket AdLib Actions' privateData is not exposed to the frontend via publications.

Testing

• I have added one or more unit tests for this PR
• I have updated the relevant unit tests
• No unit test changes are needed for this PR

Affected areas

This PR affects the Buckets area in the UI, and potentially any other DDP clients that may use related publications.

Time Frame

We consider this to be a bug worthy of fixing in release52, before it reaches the stable phase

Other Information

Status

• PR is ready to be reviewed.
• The functionality has been tested by the author.
• Relevant unit tests has been added / updated.
• Relevant documentation (code comments, system documentation) has been added / updated.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.24%. Comparing base (33514b1) to head (7c45ad8).
Report is 62 commits behind head on release52.

Files with missing lines	Patch %	Lines
meteor/server/publications/buckets.ts	0.00%	2 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##           release52    #1389      +/-   ##
=============================================
- Coverage      56.38%   56.24%   -0.14%     
=============================================
  Files            406      408       +2     
  Lines          72655    73125     +470     
  Branches        4602     4615      +13     
=============================================
+ Hits           40967    41132     +165     
- Misses         31469    31739     +270     
- Partials         219      254      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.