Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(LSG): expose parts of the current segment #1388

Open
wants to merge 7 commits into
base: release52
Choose a base branch
from

Conversation

ianshade
Copy link
Contributor

@ianshade ianshade commented Feb 20, 2025

About the Contributor

This pull request is posted on behalf of TV 2 Norge

Type of Contribution

This is a:

Feature

Current Behavior

New Behavior

Basic information about the Parts in the current Segment is added to the activePlaylist topic in the LSG.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

This PR affects the Live Status Gateway only

Time Frame

Not urgent, but we would like to get this merged into the in-development release.

Other Information

This branch also includes changes from #1367. Before that one is merged, and this one is rebased, only the last commit on this branch is to be reviewed

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@ianshade ianshade marked this pull request as ready for review February 20, 2025 12:58
@ianshade ianshade requested a review from a team as a code owner February 20, 2025 12:58
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 85.85366% with 29 lines in your changes missing coverage. Please review.

Project coverage is 56.69%. Comparing base (33514b1) to head (85fe434).
Report is 61 commits behind head on release52.

Files with missing lines Patch % Lines
...ages/live-status-gateway/src/topics/adLibsTopic.ts 75.00% 14 Missing ⚠️
...e-status-gateway/src/topics/activePlaylistTopic.ts 84.74% 9 Missing ⚠️
...-status-gateway/src/topics/helpers/segmentParts.ts 78.57% 3 Missing ⚠️
packages/live-status-gateway/src/wsHandler.ts 81.81% 1 Missing and 1 partial ⚠️
...es/live-status-gateway/src/topics/segmentsTopic.ts 96.42% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release52    #1388      +/-   ##
=============================================
+ Coverage      56.38%   56.69%   +0.30%     
=============================================
  Files            406      398       -8     
  Lines          72655    72405     -250     
  Branches        4602     4399     -203     
=============================================
+ Hits           40967    41050      +83     
+ Misses         31469    31215     -254     
+ Partials         219      140      -79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nytamin nytamin added Contribution External contribution Contribution from TV 2 Norge Contributions sponsored by TV 2 Norge (tv2.no) labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution from TV 2 Norge Contributions sponsored by TV 2 Norge (tv2.no) Contribution External contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants