-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(LSG): expose parts of the current segment #1388
Open
ianshade
wants to merge
7
commits into
nrkno:release52
Choose a base branch
from
tv2norge-collab:contribute/EAV-111
base: release52
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8cfe0d3
to
85fe434
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release52 #1388 +/- ##
=============================================
+ Coverage 56.38% 56.69% +0.30%
=============================================
Files 406 398 -8
Lines 72655 72405 -250
Branches 4602 4399 -203
=============================================
+ Hits 40967 41050 +83
+ Misses 31469 31215 -254
+ Partials 219 140 -79 ☔ View full report in Codecov by Sentry. |
5ca0448
to
85fe434
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Contribution from TV 2 Norge
Contributions sponsored by TV 2 Norge (tv2.no)
Contribution
External contribution
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of TV 2 Norge
Type of Contribution
This is a:
Feature
Current Behavior
New Behavior
Basic information about the Parts in the current Segment is added to the activePlaylist topic in the LSG.
Testing
Affected areas
This PR affects the Live Status Gateway only
Time Frame
Not urgent, but we would like to get this merged into the in-development release.
Other Information
This branch also includes changes from #1367. Before that one is merged, and this one is rebased, only the last commit on this branch is to be reviewed
Status