-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose persistent playout store to more methods #1386
base: release53
Are you sure you want to change the base?
Conversation
…ay adlibs, so it is now consistently called "Adlib Testing" instead of "Rehearsal Mode" (which is something completely different) or "Adlib Testing mode" or "Adlib Testing (Rehearsal) mode".
Rename the user-facing feature so it is consistently called "Adlib Testing"
This PR is written off the release52 branch, which results in some unrelated commits being shown in the PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release53 #1386 +/- ##
=============================================
+ Coverage 56.25% 56.27% +0.01%
=============================================
Files 408 409 +1
Lines 73093 73189 +96
Branches 4203 4195 -8
=============================================
+ Hits 41122 41185 +63
- Misses 31731 31799 +68
+ Partials 240 205 -35 ☔ View full report in Codecov by Sentry. |
About the Contributor
This pull request is posted on behalf of the BBC.
Type of Contribution
This is a: Feature
Current Behavior
It would be useful to have some sort of persistent arbitrary data storage space to use across a rundown for access in the Action / OnSetAsNext / OnTake contexts.
Similar to the persistent state in onTimelineGenerate, in fact it would probably be useful if this was the same store?
Currently data has to be stored in pieces on the timeline which is somewhat messy.
New Behavior
The
previousPersistentState
property on the RundownPlaylist has been expanded in scope to serve this purpose. This results in some small api changes in various blueprint methods, but updating to these will be trivial to do, and typescript will guide through any potential errors.Testing
Affected areas
Time Frame
Other Information
Status