Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose persistent playout store to more methods #1386

Open
wants to merge 9 commits into
base: release53
Choose a base branch
from

Conversation

Julusian
Copy link
Contributor

About the Contributor

This pull request is posted on behalf of the BBC.

Type of Contribution

This is a: Feature

Current Behavior

It would be useful to have some sort of persistent arbitrary data storage space to use across a rundown for access in the Action / OnSetAsNext / OnTake contexts.
Similar to the persistent state in onTimelineGenerate, in fact it would probably be useful if this was the same store?

Currently data has to be stored in pieces on the timeline which is somewhat messy.

New Behavior

The previousPersistentState property on the RundownPlaylist has been expanded in scope to serve this purpose. This results in some small api changes in various blueprint methods, but updating to these will be trivial to do, and typescript will guide through any potential errors.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

Time Frame

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

hummelstrand and others added 8 commits January 30, 2025 10:55
…ay adlibs, so it is now consistently called "Adlib Testing" instead of "Rehearsal Mode" (which is something completely different) or "Adlib Testing mode" or "Adlib Testing (Rehearsal) mode".
Rename the user-facing feature so it is consistently called "Adlib Testing"
@Julusian Julusian requested a review from a team as a code owner February 17, 2025 14:00
@Julusian Julusian changed the base branch from release52 to release53 February 17, 2025 14:01
@Julusian
Copy link
Contributor Author

This PR is written off the release52 branch, which results in some unrelated commits being shown in the PR.

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 60.48387% with 49 lines in your changes missing coverage. Please review.

Project coverage is 56.27%. Comparing base (2215f8f) to head (7956f7b).
Report is 4 commits behind head on release53.

Files with missing lines Patch % Lines
meteor/server/migration/1_52_0.ts 14.28% 30 Missing ⚠️
...lueprints/context/services/PersistantStateStore.ts 65.62% 11 Missing ⚠️
...c/playout/model/implementation/PlayoutModelImpl.ts 42.85% 4 Missing ⚠️
packages/job-worker/src/playout/setNext.ts 50.00% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release53    #1386      +/-   ##
=============================================
+ Coverage      56.25%   56.27%   +0.01%     
=============================================
  Files            408      409       +1     
  Lines          73093    73189      +96     
  Branches        4203     4195       -8     
=============================================
+ Hits           41122    41185      +63     
- Misses         31731    31799      +68     
+ Partials         240      205      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nytamin nytamin added Contribution External contribution Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) Contribution External contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants