Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: testtool - show AB-Session in Timeline #1385

Draft
wants to merge 1 commit into
base: release53
Choose a base branch
from

Conversation

olzzon
Copy link
Contributor

@olzzon olzzon commented Feb 17, 2025

About the Contributor

This PR is made on behalf of BBC

Type of Contribution

This is a feature

Current Behavior

Currently there's no way to see abSessions in test tools

New Behavior

if there's an abSessions object in the TimelineObject, AB-Sessions will be displayed in the timeline after the content.
As the abSessions are not part of the ResolvedTimelineObjectInstance<Content> but still in the object, a ts-expect-error has been added.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

Only the testtools timeline

Time Frame

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release53@955d96e). Learn more about missing BASE report.

Additional details and impacted files
@@             Coverage Diff              @@
##             release53    #1385   +/-   ##
============================================
  Coverage             ?   56.27%           
============================================
  Files                ?      408           
  Lines                ?    73094           
  Branches             ?     4606           
============================================
  Hits                 ?    41136           
  Misses               ?    31818           
  Partials             ?      140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nytamin nytamin added Contribution External contribution Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) Contribution External contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants