fix: simplify meteor collection auth checks #1381
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the BBC
Type of Contribution
This is a: Bug fix / Code improvement
Current Behavior
The implementation of these auth checks is a confusing hack currently, due to bugs in meteor.
New Behavior
This updates meteor to the fixed version, and tidies up the hack
This removes some deprecation warnings
See meteor/meteor#13444
The vite config change is to resolve issues during development connecting to vite through a reverse proxy (which is important for testing the auth), as it would reject any hostname
Testing
Affected areas
Time Frame
Not urgent, but we would like to get this merged into the in-development release.
The version in r52 works, I see no reason to change it there.
Other Information
Status