Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Shuttle WebHID prompter controller support #1372

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

ianshade
Copy link
Contributor

About the Contributor

This pull request is posted on behalf of TV 2 Norge

Type of Contribution

This is a:

Feature

Current Behavior

New Behavior

New mode called shuttlewebhid is added to the Prompter View, in which a Contour ShuttleXpress (Multimedia Controller Xpress) can be used to control the prompter through web browser's WebHID API.
In this mode, when opening the Prompter View for the first time, it is necessary to press the Connect to Contour Shuttle button in the top left corner of the screen, select the device, and press Connect.
Input mapping is predefined and shown in the image added to the documentation. Further contributions making it more customizable are welcome, should anyone need it.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

This PR affects the Prompter View

Time Frame

Not urgent, but it would be nice to have in release 52

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@ianshade ianshade requested a review from a team as a code owner January 29, 2025 15:28
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.49%. Comparing base (054dcb1) to head (1c17e72).
Report is 31 commits behind head on release52.

Additional details and impacted files
@@             Coverage Diff             @@
##           release52    #1372    +/-   ##
===========================================
  Coverage      56.48%   56.49%            
===========================================
  Files            401      401            
  Lines          72257    72296    +39     
  Branches        4170     4569   +399     
===========================================
+ Hits           40816    40842    +26     
- Misses         31204    31318   +114     
+ Partials         237      136   -101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jstarpl jstarpl added Contribution External contribution Contribution from TV 2 Norge Contributions sponsored by TV 2 Norge (tv2.no) labels Jan 30, 2025
@nytamin nytamin merged commit 063021b into nrkno:release52 Feb 3, 2025
34 checks passed
@ianshade ianshade deleted the contribute/EAV-297 branch February 19, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution from TV 2 Norge Contributions sponsored by TV 2 Norge (tv2.no) Contribution External contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants