Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(LSG): add packages topic #1371

Open
wants to merge 2 commits into
base: release53
Choose a base branch
from

Conversation

ianshade
Copy link
Contributor

@ianshade ianshade commented Jan 28, 2025

About the Contributor

This pull request is posted on behalf of TV 2 Norge

Type of Contribution

This is a:

Feature

Current Behavior

New Behavior

Package statuses are published as an LSG topic.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

This PR affects the Live Status Gateway functionally. In order to achieve that, some types and a publication used by other packages in the core monorepo are moved around

Time Frame

Not urgent, but it would be nice to have in release 52

Other Information

This branch also includes changes from #1367. Before that one is merged, and this one is rebased, only the latest commit on this branch is to be reviewed.

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@ianshade ianshade requested a review from a team as a code owner January 28, 2025 22:57
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 56.14525% with 157 lines in your changes missing coverage. Please review.

Project coverage is 56.81%. Comparing base (054dcb1) to head (5308430).
Report is 13 commits behind head on release52.

Files with missing lines Patch % Lines
packages/live-status-gateway/src/wsHandler.ts 14.14% 84 Missing and 1 partial ⚠️
...ckages/live-status-gateway/src/helpers/equality.ts 6.81% 41 Missing ⚠️
...ages/live-status-gateway/src/topics/adLibsTopic.ts 75.00% 14 Missing ⚠️
...e-status-gateway/src/topics/activePlaylistTopic.ts 84.21% 9 Missing ⚠️
...ations/pieceContentStatusUI/rundown/publication.ts 0.00% 6 Missing ⚠️
...ns/pieceContentStatusUI/rundown/regenerateItems.ts 0.00% 1 Missing ⚠️
...es/live-status-gateway/src/topics/segmentsTopic.ts 96.42% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release52    #1371      +/-   ##
=============================================
+ Coverage      56.48%   56.81%   +0.33%     
=============================================
  Files            401      392       -9     
  Lines          72257    71692     -565     
  Branches        4170     4403     +233     
=============================================
- Hits           40816    40735      -81     
+ Misses         31204    30855     -349     
+ Partials         237      102     -135     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nytamin nytamin added Contribution External contribution Contribution from TV 2 Norge Contributions sponsored by TV 2 Norge (tv2.no) labels Jan 29, 2025
@nytamin nytamin changed the base branch from release52 to release53 February 4, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution from TV 2 Norge Contributions sponsored by TV 2 Norge (tv2.no) Contribution External contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants