Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new SourceLayer Types #1366

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Conversation

mint-dewit
Copy link
Contributor

About the Contributor

This pull request is posted on behalf of the BBC.

Type of Contribution

This contribution is an addition to the existing source layers.

New Behavior

  • Added an additional source layer type for Lighting, no additional features added for this but it is useful to have for organisation
  • Added a new source layer type called Remote Speak: this is similar to a live speak but the VT Content is replaced with a Remote source.
  • Adjusted the styling of the Live Speak pieces to have slightly different proportions and made it easier to distinguish to colours

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

This PR mostly affects how pieces are displayed in the UI.

Time Frame

Not urgent, but we would be nice to have in release 52 :)

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

mint-dewit and others added 3 commits January 20, 2025 15:06
…ypes so that main upper section of the pieces are made 20% taller, and lower green section of the pieces (representing audio) is made 20% smaller. Also added a 1 pixel high semi-transparent separator to aid color-deficient users in seeing the contrast, especially for the liveSpeak pieces with blue/green tones.

The justification for this change is to visually separate these pieces from split pieces.
@mint-dewit mint-dewit requested a review from a team as a code owner January 27, 2025 13:59
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 56.46%. Comparing base (c77b6a5) to head (ca872a1).
Report is 62 commits behind head on release52.

Files with missing lines Patch % Lines
meteor/server/api/rest/v1/typeConversion.ts 0.00% 12 Missing ⚠️
meteor/server/lib/rest/v1/showstyles.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release52    #1366      +/-   ##
=============================================
+ Coverage      56.44%   56.46%   +0.01%     
=============================================
  Files            401      401              
  Lines          72105    72271     +166     
  Branches        4551     4175     -376     
=============================================
+ Hits           40698    40806     +108     
+ Misses         31273    31263      -10     
- Partials         134      202      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jstarpl jstarpl changed the title Feat/new sourcelayers feat: add new SourceLayer Types Jan 28, 2025
@nytamin nytamin added Contribution External contribution Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) labels Jan 29, 2025
@nytamin nytamin merged commit 1b31e45 into nrkno:release52 Feb 3, 2025
33 of 34 checks passed
@Julusian Julusian deleted the feat/new-sourcelayers branch February 4, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) Contribution External contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants