Misc. ironside work september 3. #3202
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianBoe
force-pushed
the
ncs_ps
branch
2 times, most recently
from
dc098ca to
546e163
Compare
SebastianBoe
changed the title
jonathannilsen
requested changes
Aug 20, 2025
karstenkoenig
approved these changes
Aug 20, 2025
nordicjm
reviewed
Aug 20, 2025
Comment on lines
+46
to
+49
| # Use CMAKE_VERBOSE_MAKEFILE to silence an unused-variable warning. | ||
| if(CMAKE_VERBOSE_MAKEFILE) | ||
| endif() |
There was a problem hiding this comment.
I got 5 lines of warning in the logs when this variable went unreferenced.
I assume SYSBUILD passes it to each image, and Zephyr usually references it, but since I have this minimal Zephyr it goes unreferenced.
|
@karstenkoenig , @jonathannilsen , @nordicjm : All feedback addressed, will reupload to upstream zephyr soon. |
jonathannilsen
approved these changes
Aug 21, 2025
|
These patches are now up for review upstream in zephyrproject-rtos/zephyr#94796 |
SebastianBoe
changed the title
nordicjm
approved these changes
Sep 3, 2025
jonathannilsen
approved these changes
Sep 3, 2025
SebastianBoe
changed the title
SebastianBoe
force-pushed
the
ncs_ps
branch
4 times, most recently
from
444148b to
d14185f
Compare
SebastianBoe
force-pushed
the
ncs_ps
branch
9 times, most recently
from
d8549e9 to
386427c
Compare
jonathannilsen
force-pushed
the
ncs_ps
branch
from
386427c to
0ed780b
Compare
jonathannilsen
force-pushed
the
ncs_ps
branch
from
0ed780b to
44b9823
Compare
…PET_ROOT When SNIPPET is added to the build, it is added to all images. But not all images have the test directory added to their SNIPPET_ROOT, so we also update the SNIPPET_ROOT. This allows, for instance, the uicr image of nrf54H to find this snippet. Ref: NCSDK-NONE Signed-off-by: Sebastian Bøe <[email protected]> (cherry picked from commit 5f9d20c)
Reorganize how gen_uicr.py is invoked. Instead of invoking it from one of the Zephyr images we invoke it from a new special Zephyr image called uicr. This uicr Zephyr image is flashed in the same way as normal Zephyr images so special handling in the runner is no longer necessary. Also, we simplify gen_uicr.py by moving parsing of Kconfig/DT from gen_uicr.py to CMake. Signed-off-by: Sebastian Bøe <[email protected]> (cherry picked from commit ac851ca)
…E bug Fix bug where users were unable to name their binary Bøe when building for nrf54h20. Signed-off-by: Sebastian Bøe <[email protected]> (cherry picked from commit 180f1f8)
Update the C struct for UICR to the latest revision. Signed-off-by: Sebastian Bøe <[email protected]> (cherry picked from commit 67b0e04)
Add support for secondary firmware in gen_uicr.py. Signed-off-by: Sebastian Bøe <[email protected]> (cherry picked from commit 3648cd8)
Added support for the IronSide bootmode service which allows requesting a reboot into secondary firmware boot mode. In this mode, the secondary configuration defined in UICR is applied instead of the primary one. The service provides the ironside_bootmode_secondary_reboot() function that can pass message data to the boot report of the CPU booted in the secondary boot mode. Signed-off-by: Sebastian Bøe <[email protected]> (cherry picked from commit 377a18c)
Clean up error code docs. Signed-off-by: Sebastian Bøe <[email protected]> (cherry picked from commit 363bad0)
Although not reproducible locally, it has been observed in CI that the uicr image will not always be the last image to be run. To ensure it is the last image to be run we have it depend on the 'image' image when defined. The uicr image is generated based on all other images in the build and must therefore run last. Upstream PR #: 95785 Signed-off-by: Sebastian Bøe <[email protected]>
jonathannilsen
force-pushed
the
ncs_ps
branch
from
44b9823 to
904fc04
Compare
|
Superseded by #3276 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc. ironside work september 3.