Skip to content

[collab-nrfx-4.0] Temporarily revert grtc optimization #25201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[collab-nrfx-4.0] Temporarily revert grtc optimization #25201

wants to merge 5 commits into from

Conversation

@nika-nordic
Copy link
Contributor

@nika-nordic nika-nordic commented Oct 23, 2025 •
edited
Loading

To check if GRTC changes are root of failures observed on collab-nrfx-4.0.

test-sdk-nrf: collab-nrfx-4.0

@nika-nordic
Revert "samples: bluetooth: align to nrfx 4.0"
e184e54 
This reverts commit 1a32b39.
@nika-nordic
manifest: update sdk-zephyr and nrfx
e7888ff 
To check if revert of GRTC read optimizations
solves CI issues.

Signed-off-by: Nikodem Kastelik <[email protected]>
@NordicBuilder NordicBuilder added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 23, 2025
@nika-nordic nika-nordic marked this pull request as ready for review October 23, 2025 11:43
@nika-nordic nika-nordic requested review from a team as code owners October 23, 2025 11:43
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 23, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
nrfx https://github.com/nrfconnect/nrfx/commit/2bb95f2bf701c060f795ab20cff1f57c27c96900 (4.0-dev) https://github.com/nrfconnect/nrfx/pull/1005 nrfconnect/nrfx#1005/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 23, 2025 •
edited
Loading

CI Information

To view the history of this post, click the 'edited' button above
Build number: 8

Inputs:

Sources:

sdk-nrf: PR head: 115de9b525e9561697be29b9cc991102b52f455b

more details

sdk-nrf:

PR head: 115de9b525e9561697be29b9cc991102b52f455b
merge base: 1a32b39c6bd8781bc242f33f1bce53f493d9807f
target head (collab-nrfx-4.0): 1a32b39c6bd8781bc242f33f1bce53f493d9807f
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1) 
west.yml

Outputs:

Toolchain

Version: 2b2cd9579a
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:2b2cd9579a_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
  • ✅ Integration tests
Disabled integration tests
    • desktop52_verification
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-rpc
    • test-low-level
    • test-sdk-wifi

Note: This message is automatically posted and updated by the CI

@nika-nordic
manifest: bring sdk-zephyr back to collab-nrfx-4.0
4a72d61 
To verify nrfy_grtc changes while keeping nrfx_grtc changes

Signed-off-by: Nikodem Kastelik <[email protected]>
@nika-nordic
Revert "Revert "samples: bluetooth: align to nrfx 4.0""
c6a1b35 
This reverts commit e184e54.
@nika-nordic
manifest: update nrfx to have fix for GRTC counter masking
115de9b 
Proper bitmask needs to be used when reading GRTC counter.

Signed-off-by: Nikodem Kastelik <[email protected]>
@nika-nordic
Copy link
Contributor Author

Closing in favor of proper fix PR: #25224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@masz-nordic masz-nordic Awaiting requested review from masz-nordic

Assignees

No one assigned

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM manifest manifest-nrfx manifest-zephyr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nika-nordic @NordicBuilder