Additional logging to improve tracking of failed image validation/signature check #438
+186
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-nordic
force-pushed
the
additional-logs
branch
from
dc8fcec to
a2b1cf2
Compare
de-nordic
force-pushed
the
additional-logs
branch
2 times, most recently
from
1dfe6dd to
3a39683
Compare
nvlsianpu
approved these changes
May 28, 2025
nordicjm
approved these changes
Jun 4, 2025
de-nordic
force-pushed
the
additional-logs
branch
7 times, most recently
from
5c42218 to
2e7c7fe
Compare
de-nordic
force-pushed
the
additional-logs
branch
2 times, most recently
from
87f8393 to
5e67e49
Compare
This reverts commit 38e8159. Signed-off-by: Dominik Ermel <[email protected]>
This reverts commit c75fc59. Signed-off-by: Dominik Ermel <[email protected]>
This reverts commit 105551f. Signed-off-by: Dominik Ermel <[email protected]>
This reverts commit 36c1fdf. Signed-off-by: Dominik Ermel <[email protected]>
…ssion" This reverts commit 4538b4d. Signed-off-by: Dominik Ermel <[email protected]>
…ture key" This reverts commit 6f91355. Signed-off-by: Dominik Ermel <[email protected]>
This reverts commit d20d66d. Signed-off-by: Dominik Ermel <[email protected]>
Consolidates USB DFU entry logic by unifying GPIO and timeout-based DFU triggers under a common flag. This avoids code duplication and improves maintainability. Also improves log clarity for different DFU exit conditions. Signed-off-by: Sayooj K Karun <[email protected]> (cherry picked from commit 402d3f7ff11973577f1bc966151fccf53192f32b) Signed-off-by: Dominik Ermel <[email protected]>
Add additional log lines to allow easier tracking potential failures in image validation. Upstream PR #: 2308 Signed-off-by: Dominik Ermel <[email protected]>
Improve logging to make it easier to track image validation failures in development. Upstream PR #: 2308 Signed-off-by: Dominik Ermel <[email protected]> (cherry picked from commit 1609c024c6934b89e892324379f7ef88bd4e915e)
Adds support for LZMA-compressed firmware updates which also supports encrypted images and supports more than 1 updateable image Signed-off-by: Jamie McCrae <[email protected]> Signed-off-by: Michal Kozikowski <[email protected]> Signed-off-by: Dominik Ermel <[email protected]> (cherry picked from commit 38e8159) (cherry picked from commit 2f691b7) (cherry picked from commit d20d66d)
The commit adds verification of image using keys stored in KMU. Signed-off-by: Dominik Ermel <[email protected]> (cherry picked from commit 3e3db4b) (cherry picked from commit 6f91355)
Adds selecting the experimental Kconfig when compession is in use Signed-off-by: Jamie McCrae <[email protected]> Signed-off-by: Dominik Ermel <[email protected]> (cherry picked from commit 26b638c) (cherry picked from commit 4538b4d)
Adds a new Kconfig CONFIG_BOOT_SIGNATURE_KMU_SLOTS which allows specifying how many KMU key IDs are supported, the default is set to 1 instead of 3 which was set before NCSDK-30743 Signed-off-by: Jamie McCrae <[email protected]> Signed-off-by: Dominik Ermel <[email protected]> (cherry picked from commit 8a366a3) (cherry picked from commit 36c1fdf)
Disable previous generation key when update comes with new valid key and application is confirmed. Signed-off-by: Mateusz Michalek <[email protected]> Signed-off-by: Dominik Ermel <[email protected]> (cherry picked from commit 22c2cac) (cherry picked from commit 105551f)
This commit aligns to the changes in the nrfcompress API, which now enables the caller to provide the expected size of the decompressed image. ref: NCSDK-32340 Signed-off-by: Michal Kozikowski <[email protected]> Signed-off-by: Dominik Ermel <[email protected]> (cherry picked from commit e110d76) (cherry picked from commit c75fc59)
de-nordic
force-pushed
the
additional-logs
branch
from
5e67e49 to
9ec8c5b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR now contains commit
that is not related to logging, but I have placed logs around this and needed to pick it to avoid merge conflicts.