Closed
Conversation
Contributor
wangzhao0217
commented
Jun 4, 2025
wangzhao0217
commented
- exmaine the existing cycle infrastructure
- update on Global/Local Efficiency calculation
Contributor
Author
|
This PR is updating the calculation of Global and local efficiency using OD data: Core network: |
Robinlovelace
approved these changes
Jun 4, 2025
|
|
||
| ### Function: Compute Zone Connectivity | ||
| compute_zone_connectivity = function(intermediate_zone, lads, city_name = "City of Edinburgh", buffer_intersection, density_quantile = 0.3) { | ||
| compute_zone_connectivity = function(intermediate_zone, lads, city_name = "City of Edinburgh", rnet_core, buffer_distance = 500, density_quantile = 0.3) { |
Contributor
There was a problem hiding this comment.
Good to see buffer_distance argument in use.
Robinlovelace
approved these changes
Jun 9, 2025
Contributor
|
Although tests not passing, right? Those should be fixed before merging if possible. |
Contributor
Author
Yes, will work on that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.