refactor: request dependency resolution from language server#96
refactor: request dependency resolution from language server#96
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughRefactors the VS Code extension to delegate workspace and dependency-resolution logic to the language server. Removes client-side workspace composables and core workspace adapters, centralises request registration by adding new request modules on both client and server, introduces a typed resolved-dependencies request and package-manager request wiring, updates imports and TypeScript path aliases, and removes two devDependencies from the extension package configuration. Possibly related PRs
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
extensions/vscode/src/utils/request.ts (1)
7-15: Consider adding an explicit return type for the exported function.The return type is correctly inferred, but for exported API functions, an explicit return type improves discoverability and guards against accidental signature changes.
♻️ Suggested improvement
-export async function getResolvedDependencies(client: BaseLanguageClient, uri: Uri) { +export async function getResolvedDependencies(client: BaseLanguageClient, uri: Uri): Promise<GetResolvedDependenciesRequest.ResponseType> { return client.sendRequest(getResolvedDependenciesRequestType, { uri: uri.toString() }) }
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: fdd025f3-5df4-4f47-97da-3b2933f60260
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (13)
extensions/vscode/package.jsonextensions/vscode/src/client.tsextensions/vscode/src/composables/workspace-context.tsextensions/vscode/src/core/workspace.tsextensions/vscode/src/index.tsextensions/vscode/src/providers/decorators.tsextensions/vscode/src/request.tsextensions/vscode/src/utils/request.tsextensions/vscode/tsconfig.jsonextensions/vscode/tsdown.config.tspackages/language-server/src/request.tspackages/language-server/src/server.tspackages/shared/src/protocol.ts
💤 Files with no reviewable changes (4)
- extensions/vscode/tsdown.config.ts
- extensions/vscode/package.json
- extensions/vscode/src/composables/workspace-context.ts
- extensions/vscode/src/core/workspace.ts
Remove client-side workspace logic, request dependency resolution from the existing language server.