Skip to content

refactor: migrate shared dir to an internal package#95

Merged
9romise merged 1 commit intomainfrom
shared
Apr 1, 2026
Merged

refactor: migrate shared dir to an internal package#95
9romise merged 1 commit intomainfrom
shared

Conversation

@9romise
Copy link
Copy Markdown
Member

@9romise 9romise commented Apr 1, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

📝 Walkthrough

Walkthrough

This pull request restructures the codebase to convert an internal shared directory (previously referenced via #shared/* path aliases) into a published workspace package called npmx-shared. The changes establish a new packages/shared package with corresponding TypeScript and build configuration files, then systematically update all import statements across the VS Code extension and language service packages to consume shared modules (commands, constants, meta, protocol, types) from npmx-shared/* instead of the path aliases. Additionally, the pull request removes #shared/* mappings from TypeScript configurations, eliminates ./package.json export entries from language-core, language-server, and language-service packages, and updates build configurations to prevent automatic generation of package.json exports.

Possibly related PRs

  • PR 92: Introduces the shared modules (commands, constants, meta, protocol) that form the basis of the new npmx-shared package exports.
  • PR 81: Performs the same monorepo migration pattern of converting path-alias imports to a native published package and updating associated configuration files.
  • PR 87: Updates the VS Code extension source files (client.ts, index.ts) that are directly affected by the import path changes in this refactoring.
🚥 Pre-merge checks | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The pull request lacks an author-provided description, making it impossible to assess alignment with the changeset. Add a pull request description explaining the changes, rationale for migrating the shared directory to an internal package, and any breaking changes or migration steps.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch shared

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e7b8ee0a-0b51-4da4-9078-adede99fc616

📥 Commits

Reviewing files that changed from the base of the PR and between 09032ff and bf9678f.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (27)
  • .gitignore
  • extensions/vscode/package.json
  • extensions/vscode/src/client.ts
  • extensions/vscode/src/commands/add-to-ignore.ts
  • extensions/vscode/src/index.ts
  • extensions/vscode/src/state.ts
  • extensions/vscode/tsconfig.json
  • packages/language-core/package.json
  • packages/language-core/tsdown.config.ts
  • packages/language-server/package.json
  • packages/language-server/src/workspace.ts
  • packages/language-server/tsconfig.json
  • packages/language-server/tsdown.config.ts
  • packages/language-service/package.json
  • packages/language-service/src/config.ts
  • packages/language-service/src/plugins/diagnostics/actions.ts
  • packages/language-service/src/plugins/diagnostics/index.ts
  • packages/language-service/tsconfig.json
  • packages/language-service/tsdown.config.ts
  • packages/shared/package.json
  • packages/shared/src/commands.ts
  • packages/shared/src/constants.ts
  • packages/shared/src/protocol.ts
  • packages/shared/src/types.ts
  • packages/shared/tsconfig.json
  • packages/shared/tsdown.config.ts
  • tsconfig.json

@9romise 9romise added this pull request to the merge queue Apr 1, 2026
Merged via the queue into main with commit 9edd184 Apr 1, 2026
11 checks passed
@9romise 9romise deleted the shared branch April 1, 2026 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant