feat(i18n): update Indonesian localization#2334
feat(i18n): update Indonesian localization#2334alfonsusac wants to merge 3 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Hello! Thank you for opening your first PR to npmx, @alfonsusac! 🚀 Here’s what will happen next:
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis pull request updates the Indonesian locale JSON (i18n/locales/id-ID.json) with numerous additions and edits: new top-level keys for branding and logo menu, expanded settings (including accent colours and background themes), many new UI labels and accessibility/help texts across package, code, compare and download sections, populated previously empty translation objects (translation_status.table, download, action_bar, vacations), and multiple wording changes (e.g., file/tree terminology and compare/diff strings). Total delta in the file: +229/−38 lines. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
i18n/locales/id-ID.json (1)
826-852: Minor inconsistency: "Berkas" vs "File" terminology.The PR objective mentions changing "Berkas" to "File" for consistency with Indonesian UI conventions. The new/modified lines correctly use "file" (e.g., lines 827, 830, 831, 834, 837, 841, 842, 852), but line 826 (
files_label) still uses "Berkas".Consider updating line 826 for consistency:
- "files_label": "Berkas", + "files_label": "File",This is a minor issue since it doesn't break functionality, but it would improve terminology consistency across the file.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f9402679-b5ff-4a80-8edf-bf666e7408ff
📒 Files selected for processing (1)
i18n/locales/id-ID.json
This PR completes the Indonesian (id-ID) translation by adding all missing keys. All 1142 translation keys are covered.
BerkastoFilesince File is more widely used in Indonesian UIs, apps, and everyday speech.