feat: add cursor-pointer to ButtonBase component#2202
feat: add cursor-pointer to ButtonBase component#2202thealxlabs wants to merge 2 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis pull request modifies the Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can approve the review once all CodeRabbit's comments are resolved.Enable the |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Closing this PR. You've opened 14 PRs in a matter of minutes, which is a clear sign of automated bulk submissions with no genuine engagement. While AI tools can be helpful for coding assistance, our project requires genuine human involvement. We've outlined this clearly in our contribution guidelines. If you're genuinely interested in contributing to npmx.dev:
Mass-generated PRs like these won't be accepted. We welcome real contributions from developers who want to be part of our community. |
🔗 Linked issue
resolves #1760
🧭 Context
The
ButtonBasecomponent (app/components/Button/Base.vue) lacked an explicitcursor-pointerclass. Browsers default tocursor: autofor<button>elements styled with Tailwind/UnoCSS resets, so clickable buttons appeared with the default arrow cursor instead of the expected pointer.📚 Description
Added
cursor-pointerto the button's static class list so all enabledButtonBaseinstances show the pointer cursor. The existingdisabled:(cursor-not-allowed)modifier is preserved and continues to override on disabled buttons.A regression test (
test/nuxt/components/ButtonBase.spec.ts) mounts the component and asserts thatcursor-pointeris present on the enabled button andcursor-not-allowedis in the class string for the disabled state.