-
-
Notifications
You must be signed in to change notification settings - Fork 382
feat(ui): add β+K command palette for quick nav and actions #2159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
serhalp
wants to merge
34
commits into
main
Choose a base branch
from
serhalp/cmdk-palette
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
9983364
feat(ui): add command palette for quick navigation and actions
serhalp 1036612
Merge remote-tracking branch 'origin/main' into serhalp/cmdk-palette
ghostdevv c9b5586
fix: address valid CodeRabbit feedback
serhalp 651ba8a
refactor: avoid route type error
serhalp 9c155a3
refactor: actually actually fix that route type
serhalp b515456
[autofix.ci] apply automated fixes
autofix-ci[bot] bfc524b
Merge remote-tracking branch 'origin/main' into serhalp/cmdk-palette
ghostdevv c9ad183
Merge branch 'main' into serhalp/cmdk-palette
serhalp e5a5ffd
fix: use trimmed query consistently
serhalp 4354dcf
test(a11y): explicitly test for announcer existence
serhalp 642d277
fix(a11y): remove unnecessary aria-labelledby
serhalp 9271263
fix: don't change active command on hover
serhalp ae8e1b1
refactor: use pure CSS for active palette command styling
serhalp b4a6398
fix: add back the body.appendChild(a) in download util
serhalp 19f242f
test: fix cmd palette a11y test
serhalp f10f375
Merge remote-tracking branch 'origin/main' into serhalp/cmdk-palette
serhalp 7efb8c4
refactor: extract and use util to parse package name
serhalp 5bb5e1c
fix: announce package tarball download from command palette
serhalp a7c1e09
refactor: avoid .then().finally()
serhalp 218de39
fix(a11y): announce more command palette actions
serhalp 3e2e8a5
fix: actually persist selected locale via cmd palette
serhalp 3959303
fix: refactor away i18n key interpolation
serhalp 13e6fab
fix: make "Search" nav item and "Search for query" separate
serhalp 471200c
test: update test fetch mocks for new calls
serhalp e797864
fix: add missing id to keyboard shortcuts modal
serhalp e867eb1
fix: only show copy-markdown command when appropriate
serhalp 2c67363
fix: align cmd palette items vertically
serhalp f70c603
fix: remove imports from onPrehydrate
serhalp e86c3b2
fix: actually restore the default accent color
serhalp 2072386
test: update default accent color in tests
serhalp 7fb4201
[autofix.ci] apply automated fixes
autofix-ci[bot] 112db46
fix: simplify palette package versions loading a bit
serhalp 8e868d4
fix: work around double scrollbar Safari bug π
serhalp 68956c0
Merge remote-tracking branch 'origin/main' into serhalp/cmdk-palette
serhalp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -144,6 +144,8 @@ if (import.meta.client) { | |
| <NuxtPage /> | ||
| </div> | ||
|
|
||
| <CommandPalette /> | ||
|
|
||
| <AppFooter /> | ||
|
|
||
| <ScrollToTop /> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.