fix(arborist): Add better error message when lockfile is malformed #8268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owlstronaut
force-pushed
the
owlstronaut/6997
branch
from
aab72e9 to
cc0d28a
Compare
wraithgar
reviewed
May 1, 2025
owlstronaut
force-pushed
the
owlstronaut/6997
branch
from
cc0d28a to
83eb43c
Compare
wraithgar
reviewed
May 3, 2025
adamalston
reviewed
May 11, 2025
owlstronaut
force-pushed
the
owlstronaut/6997
branch
from
83eb43c to
285c2cc
Compare
wraithgar
approved these changes
May 14, 2025
Nokel81
reviewed
May 14, 2025
| const err = new Error( | ||
| `Missing target in lock file: "${targetLoc}" is referenced by "${location}" but does not exist. | ||
| To fix: | ||
| 1. rm package-lock.json |
There was a problem hiding this comment.
This is actually a bit too explosive. A more graceful fix would be to just remove the reference location from the package lock and then run npm i which fixes the issue.
There was a problem hiding this comment.
Oops, That was supposed to be removed
There was a problem hiding this comment.
That comment was only about removing node modules.
There was a problem hiding this comment.
We don't ever recommend people manually edit their package-lock file. The real fix would be for npm install to fix the tree, but that's a much bigger lift.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overrides #6997 with a more standard way of expressing errors in the cli and has a test for it.