fix: add otplease for enable-2fa, disable-2fa, access #8228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reggi
commented
Apr 15, 2025
Converting to draft as an extra precaution. |
reggi
changed the title
wraithgar
reviewed
Apr 18, 2025
wraithgar
reviewed
Apr 18, 2025
This comment was marked as outdated.
This comment was marked as outdated.
reggi
commented
Apr 25, 2025
reggi
changed the title
reggi
changed the title
reggi
commented
Apr 25, 2025
wraithgar
reviewed
Apr 26, 2025
reggi
commented
Apr 29, 2025
wraithgar
reviewed
Apr 30, 2025
| } | ||
|
|
||
| log.info('profile', 'Setting two-factor authentication to ' + mode) | ||
| const challenge = await set(info, conf) | ||
| const challenge = await otplease(this.npm, conf, c => set(info, c)) |
There was a problem hiding this comment.
Suggested change
| const challenge = await otplease(this.npm, conf, c => set(info, c)) | |
| const challenge = await otplease(this.npm, conf, o => set(info, o)) |
I know this is nitpicky but I believe we have tried to consistently refer to this param as "opts", shortened to "o" sometimes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
profile enable-2faandprofile disable-2facommands a broken. This fixes them by wrapping the calls inotpleasewhich handles error headers / prompts with tfa urls.Closes: #8192