ci: adopt nownabe/workflows common checks - #50
Merged
Merged
Conversation
Call nownabe/workflows reusable pr.yaml (v1.0.2) for the common checks (actionlint, ghalint, zizmor, oxfmt, oxlint, shellcheck, secret-scan) and drop the redundant local github-actions reusable workflow. Switch change detection to dorny/paths-filter to match the nownabe/workflows style. Rust checks (fmt, clippy, test) stay local since they are not covered by the shared workflows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adjust CI to reuse the shared
nownabe/workflowscommon checks instead of maintaining GitHub Actions linting locally.nownabe/workflows/.github/workflows/pr.yaml@v1.0.2(pinned to commit SHA95b6433) as acommon-checksjob. This runs actionlint / ghalint / zizmor, plus oxfmt, oxlint, shellcheck, and secret-scan — each gated by its own path filter inside the shared workflow.reusable-check-github-actions.yaml(its actionlint/ghalint/zizmor checks are fully covered by the shared workflow).tj-actions/changed-filestodorny/paths-filterto match thenownabe/workflowsstyle.cargo fmt --check,cargo clippy -- -D warnings,cargo test) local, since the shared workflows don't cover Rust.Notes
nownabe/workflows'oxfmtalso checks YAML/TOML/JSON/Markdown, so existing files that aren't oxfmt-formatted may fail on this PR's own run — those will need to be formatted if flagged.Test
actionlint(no errors).