feat(api-service): decode special characters #7881
Draft
+40
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
commit: |
djabarovgeorge
commented
Mar 9, 2025
| @@ -829,6 +829,19 @@ export class Client { | |||
| return getCodeResult; | |||
| } | |||
| } | |||
|
|
|||
| type ChannelStepOption = { | |||
There was a problem hiding this comment.
the option type here is not correct and is hard to reuse because of its dynamic nature; therefore, i created a simple type for now.
in addition I created a ticket to solve the typing issue.
djabarovgeorge
commented
Mar 10, 2025
Comment on lines
+866
to
+873
| const skipOutputSanitization = (stepType: string, outputKey: string) => { | ||
| // Skip sanitization for string values that aren't HTML | ||
| if (outputKey === 'subject' && stepType === 'email') { | ||
| return true; | ||
| } | ||
|
|
||
| return false; | ||
| }; |
There was a problem hiding this comment.
We need to change this and do the opposite and sanitize only HTML outputs instead, as this could happen on all of the channels.
…-properly-for-email-subject
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer