Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): NV-5317 and NV-5318 #7806

Merged
merged 2 commits into from
Mar 11, 2025
Merged

fix(web): NV-5317 and NV-5318 #7806

merged 2 commits into from
Mar 11, 2025

Conversation

jainpawan21
Copy link
Member

@jainpawan21 jainpawan21 commented Feb 27, 2025 •
edited
Loading

What changed? Why was the change needed?

NV-5317

  • invalidated feed messages cache if action status is changed
  • single message should be marked as seen if it is marked as read using API

NV-5318

  • Add support of fetching image pre-signed URL to preview in dropzone

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

@linear Linear
Copy link

linear bot commented Feb 27, 2025

NV-5318 Use AWS S3 pre-signed url to fetch brand logo image

NV-5317 🐛 Issue with in-app actions button click with old notification center

@jainpawan21 jainpawan21 marked this pull request as ready for review February 27, 2025 21:50
@jainpawan21 jainpawan21 changed the title fix: NV-5317 and NV-5318 fix(web): NV-5317 and NV-5318 Feb 27, 2025
@merrcury
Copy link
Member

@jainpawan21 Can we raise it against v0.24.4 . We fixed some things in that last time. I would want to publish v0.24.5 from that branch.

@jainpawan21 jainpawan21 changed the base branch from v0.24.x to v0.24.4 March 4, 2025 12:15
@jainpawan21
Copy link
Member Author

@jainpawan21 Can we raise it against v0.24.4 . We fixed some things in that last time. I would want to publish v0.24.5 from that branch.

@merrcury Changed the base branch from v0.24.x to v0.24.4

@merrcury merrcury changed the base branch from v0.24.4 to v0.24.5 March 11, 2025 10:11
@merrcury merrcury merged commit f655ffc into v0.24.5 Mar 11, 2025
12 of 28 checks passed
@merrcury merrcury deleted the fix/roche-bug-fixes-0.24.0 branch March 11, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merrcury merrcury merrcury approved these changes

@SokratisVidros SokratisVidros Awaiting requested review from SokratisVidros

Assignees
No one assigned
Labels
@novu/api @novu/dal @novu/web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jainpawan21 @merrcury