Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api-service): validate recipients in event request parsing #7758

Open
wants to merge 11 commits into
base: next
Choose a base branch
from
Open

feat(api-service): validate recipients in event request parsing #7758

wants to merge 11 commits into from

Conversation

BiswaViraj
Copy link
Member

@BiswaViraj BiswaViraj commented Feb 21, 2025 •
edited
Loading

What changed? Why was the change needed?

  • Sanitize/trim whitespace on the IDs
  • Collect invalid IDs and log them in dry run mode
  • only use valid Ids to trigger when not in the dry run mode

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

@linear Linear
Copy link

linear bot commented Feb 21, 2025

NV-5432 Fix TypeError related to subscriberId.trim function

@BiswaViraj BiswaViraj changed the title feat(api): validate recipients in event request parsing feat(api-service): validate recipients in event request parsing Feb 21, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 21, 2025 •
edited
Loading

✅ Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit b498190
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/67cacc8a74eca5000803749e
😎 Deploy Preview https://deploy-preview-7758.dashboard.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Feb 21, 2025 •
edited
Loading

✅ Deploy Preview for dashboard-v2-novu-staging ready!

Name Link
🔨 Latest commit 5206e63
🔍 Latest deploy log https://app.netlify.com/sites/dashboard-v2-novu-staging/deploys/67cfc65a0ef0460008844527
😎 Deploy Preview https://deploy-preview-7758.dashboard-v2.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BiswaViraj BiswaViraj marked this pull request as ready for review February 21, 2025 13:20
SokratisVidros
SokratisVidros requested changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@SokratisVidros SokratisVidros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BiswaViraj please refer to Linear for the updated requirements.

@BiswaViraj BiswaViraj force-pushed the nv-5432-fix-typeerror-related-to-subscriberidtrim-function branch from 99f61a6 to 1d4ad19 Compare February 27, 2025 10:18
@BiswaViraj BiswaViraj force-pushed the nv-5432-fix-typeerror-related-to-subscriberidtrim-function branch from 1d4ad19 to ef71502 Compare February 27, 2025 16:28
@github-actions GitHub Actions
Copy link

LaunchDarkly flag references

🔍 1 flag added or modified

Name Key Aliases found Info
IS_SUBSCRIBER_ID_VALIDATION_DRY_RUN_ENABLED IS_SUBSCRIBER_ID_VALIDATION_DRY_RUN_ENABLED

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 27, 2025 •
edited
Loading

Open in Stackblitz

@novu/client

npm i https://pkg.pr.new/novuhq/novu/@novu/client@7758

@novu/headless

npm i https://pkg.pr.new/novuhq/novu/@novu/headless@7758

@novu/node

npm i https://pkg.pr.new/novuhq/novu/@novu/node@7758

@novu/notification-center

npm i https://pkg.pr.new/novuhq/novu/@novu/notification-center@7758

novu

npm i https://pkg.pr.new/novuhq/novu@7758

@novu/providers

npm i https://pkg.pr.new/novuhq/novu/@novu/providers@7758

@novu/shared

npm i https://pkg.pr.new/novuhq/novu/@novu/shared@7758

commit: 5206e63

@BiswaViraj BiswaViraj force-pushed the nv-5432-fix-typeerror-related-to-subscriberidtrim-function branch from ef71502 to db95916 Compare February 28, 2025 08:08
@BiswaViraj BiswaViraj force-pushed the nv-5432-fix-typeerror-related-to-subscriberidtrim-function branch from a0506a7 to ef45f5a Compare March 10, 2025 13:24
BiswaViraj added 10 commits March 10, 2025 18:59
@BiswaViraj
feat(api): validate recipients in event request parsing
3e2d315
@BiswaViraj
fix(shared): update subscriber ID regex to allow special characters
7fe07c4
@BiswaViraj
feat(api): enhance recipient validation with dry run feature and upda…
0192c6b 
…te subscriber ID regex
@BiswaViraj
fix(shared): update subscriber ID regex to include '@' character
8e04add
@BiswaViraj
feat(api): refactor recipient validation logic and introduce zod sche…
b920245 
…mas for improved validation
@BiswaViraj
feat(schema): enhance subscriber ID validation with regex for special…
41f549b 
… characters
@BiswaViraj
feat(api): integrate CommunityOrganizationRepository into event parsi…
594303b 
…ng logic
@BiswaViraj
refactor(api): rename subscriber variables to recipients for clarity …
426cb8e 
…and consistency
@BiswaViraj
feat(api): optimize event parsing by fetching environment and organiz…
65782a2 
…ation concurrently; enhance subscriber ID validation to accept email format
@BiswaViraj
refactor(api): remove unused subscriber email regex import from creat…
e9715e2 
…e-subscriber DTO
@BiswaViraj BiswaViraj force-pushed the nv-5432-fix-typeerror-related-to-subscriberidtrim-function branch from ef45f5a to e9715e2 Compare March 10, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SokratisVidros SokratisVidros SokratisVidros requested changes

@LetItRock LetItRock Awaiting requested review from LetItRock

@ChmaraX ChmaraX Awaiting requested review from ChmaraX

@djabarovgeorge djabarovgeorge Awaiting requested review from djabarovgeorge

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
@novu/api-service @novu/dashboard @novu/shared
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BiswaViraj @SokratisVidros