feat: add character shortcode #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-matthias
force-pushed
the
characters
branch
from
31b98ca to
5f19d44
Compare
not-matthias
force-pushed
the
characters
branch
from
5f19d44 to
6ce7d82
Compare
Playwright Tests passed!All visual regression tests passed successfully! |
not-matthias
force-pushed
the
characters
branch
from
6ce7d82 to
769bf73
Compare
Playwright Tests passed!All visual regression tests passed successfully! |
Add visual regression snapshots for character shortcode component across different browsers and viewports.
not-matthias
force-pushed
the
characters
branch
from
769bf73 to
0949caf
Compare
Playwright Tests passed!All visual regression tests passed successfully! |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a character shortcode feature that enables adding dialogue and interactive characters to blog posts. The implementation provides a flexible way to display character avatars with speech bubbles, supporting both left and right positioning.
Key Changes:
- Added new character shortcode template with support for custom avatars, positioning, and markdown content
- Created SCSS styling for character notes with theme-aware styling and responsive layout
- Added visual regression tests and documentation for the new feature
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| templates/shortcodes/character.html | New shortcode template implementing character dialogue boxes with avatar support |
| sass/parts/_character.scss | Styling for character notes including positioning, avatars, and speech bubbles |
| sass/main.scss | Import statement for the new character styles |
| content/posts/configuration.md | Documentation explaining character shortcode usage and parameters |
| content/posts/character-shortcodes.md | Example post demonstrating character shortcode functionality |
| tests/visual/character-shortcodes-visual.spec.ts | Visual regression tests for light and dark themes |
| tests/visual/character-shortcodes-visual.spec.ts-snapshots/*.png | Visual test baseline snapshots stored in Git LFS |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.