Skip to content

client/core: improve msg.Type formatting (server message handling) #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
norwnd wants to merge 1 commit into
base: master
Choose a base branch
from
Open

client/core: improve msg.Type formatting (server message handling) #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/core/core.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8379,7 +8379,7 @@ out:
c.log.Errorf("A response was received in the message queue: %s", msg)
continue
default:
c.log.Errorf("Invalid message type %d from MessageSource", msg.Type)
c.log.Errorf("Invalid message type %s from MessageSource", msg.Type)
continue
}
// Until all the routes have handlers, check for nil too.
Expand Down
2 changes: 1 addition & 1 deletion client/websocket/websocket.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ func (s *Server) Notify(route string, payload interface{}) {
// handleMessage handles the websocket message, calling the right handler for
// the route.
func (s *Server) handleMessage(conn *wsClient, msg *msgjson.Message) *msgjson.Error {
s.log.Tracef("message of type %d received for route %s", msg.Type, msg.Route)
s.log.Tracef("message of type %s received for route %s", msg.Type, msg.Route)
if msg.Type == msgjson.Request {
handler, found := wsHandlers[msg.Route]
if !found {
Expand Down
2 changes: 1 addition & 1 deletion dex/msgjson/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ func NewResponse(id uint64, result interface{}, rpcErr *Error) (*Message, error)
// Payload is []byte("null").
func (msg *Message) Response() (*ResponsePayload, error) {
if msg.Type != Response {
return nil, fmt.Errorf("invalid type %d for ResponsePayload", msg.Type)
return nil, fmt.Errorf("invalid type %s for ResponsePayload", msg.Type)
}
resp := new(ResponsePayload)
err := json.Unmarshal(msg.Payload, &resp)
Expand Down