[BUG]: PlayerEvents.Spawning/Spawned not called for roles without a spawnpoint handler

[xCynDev]

Before You Report

• I have searched for existing reports of this bug, and this bug report is unique.

Version

14.2.7

Description

Roles without a spawnpoint handler, such as SCP-049-2, will not call PlayerEvents.Spawning and PlayerEvents.Spawned. This should not be the case. These events should be called regardless.

The faulty logic can be found in RoleSpawnpointManager.SetPosition(). If there's no spawnpoint handler, the method should still call the LabAPI events with defaulted spawn position and horizontal rotation.

To Reproduce

• Bind a simple handler to PlayerEvents.Spawning and PlayerEvents.Spawned that prints when a role spawns.
• Spawn a player as SCP-049-2 via Player.SetRole(), with RoleSpawnFlags.None.
• Nothing will be printed to the logs.

Expected Behavior

• Roles without a spawnpoint handler should still call these events.

Additional Information

N/A

[xCynDev]

        if (!NetworkServer.active || newRole is not IFpcRole fpcRole)
        {
            return;
        }
        
        var position = Vector3.zero;
        var horizontalRot = 0.0f;
        var spawnpoint = fpcRole.SpawnpointHandler?.TryGetSpawnpoint(out position, out horizontalRot) ?? false;
        var eventArgs = new PlayerSpawningEventArgs(hub, newRole, spawnpoint, position, horizontalRot);
        LabApi.Events.Handlers.PlayerEvents.OnSpawning(eventArgs);
        if (!eventArgs.IsAllowed)
        {
            return;
        }
        
        position = eventArgs.SpawnLocation;
        var horizontalRotation = eventArgs.HorizontalRotation;
        var useSpawnPoint = eventArgs.UseSpawnPoint;
        if (!newRole.ServerSpawnFlags.HasFlag(RoleSpawnFlags.UseSpawnpoint) || !useSpawnPoint)
        {
            LabApi.Events.Handlers.PlayerEvents.OnSpawned(new PlayerSpawnedEventArgs(hub, newRole, useSpawnPoint, position, horizontalRotation));
        }
        else
        {
            hub.transform.position = position;
            if (fpcRole.FpcModule.MouseLook != null)
            {
                fpcRole.FpcModule.MouseLook.CurrentHorizontal = horizontalRotation;
            }
            
            LabApi.Events.Handlers.PlayerEvents.OnSpawned(new PlayerSpawnedEventArgs(hub, newRole, useSpawnPoint, position, horizontalRotation));
        }

Patched it on our end and that'd be the fix. All it does is work even without a spawnpoint handler.

[michcio15]

I don't think its a bug since onchagedrole and changingrole exists I think its more of a naming issue

[xCynDev]

Should still run without a spawnpoint handler. It makes it a lot more convenient and costs nothing.