Fix: Add multiple CS devices#185
Open
himalia416 wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation implicitly assumes a single active ranging target, which may cause incorrect or inconsistent UI behavior when multiple concurrent ranging sessions are present.
More info: The current Channel Sounding implementation does not maintain an independent state for multiple ranging devices/sessions in the ChannelSoundingViewModel class.
startChannelSounding(address) launches a new collection for each device; however, all emitted data is written into the same shared instance.
As a result, when multiple Channel Sounding sessions are started simultaneously (multiple reflectors/responders), the data streams overwrite each other in the UI state.
Similarly, the manager class was using single class-level variables (like rangingSession and device) to track active sessions. If multiple devices tried to connect at the same time, they would overwrite each other’s data, mix up distance histories, and leak system callbacks.