Fix edge case -- 0.5% of UIDs got wrong result #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old code was almost, but not quite, doing simple addition of large (48-bit) numbers. However, the carry bit was not properly handled. Specifically, when the temporary 16-bit `carry_sum` would have low eight bits of `0xff` and `carry_sum` from prior addition was non-zero. Frankly, I'm not sure if this is a bug, or intentionally slightly different from just doing addition and checking the carry flag? It just looked like it was 99.5% implementing addition of multi-byte values. Then, the proxmark code actually ***did*** just use multi-byte addition. It could be a bug in this code (and fixed with this change), or maybe the KDF intentionally did this, and the author of the proxmark version of the code didn't notice this edge case, and thought the KDF was properly implementing addition?
|
Verified, nice catch! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The carry bit should have been applied to the summation before saving the result.
Only a small percentage of UIDs affected, because required that both
carry_sumlow byte was0xffand that carry flag from prior addition was non-zero.