Decode invalid Matrix user IDs #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The events currently do not show diagnosis for events that went wrong - this is something that should be improved later.
BramvdnHeuvel
commented
Nov 22, 2024
| ) | ||
| localpart | ||
| isHistorical ({ localpart } as u) = | ||
| String.all validHistoricalLocalpartChar localpart && not (isModern u) |
There was a problem hiding this comment.
Given that most user IDs are modern in the Matrix ecosystem, this might compute slightly faster if the second option is computed first.
BramvdnHeuvel
commented
Nov 22, 2024
|
|
||
|
|
||
| localpartParser : Parser String | ||
| localpartParser = | ||
| P.chompIf validHistoricalUsernameChar | ||
| -- Yes, some illegal users have a zero-length localpart | ||
| P.chompWhile (\c -> c /= ':') |
There was a problem hiding this comment.
Given that the parser is multiplied, make sure that this passes the tests.
BramvdnHeuvel
commented
Nov 22, 2024
| invite.events | ||
| } | ||
| if UserId.isIllegal event.sender then | ||
| invite |
There was a problem hiding this comment.
Obsolete: illegal users can no longer appear beyond JSON coders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As referenced in an issue on the Synapse repository, Synapse servers do not sanitize
senderfields and hence allow invalid users to exist. Examples are@:example.organd@🐈:example.org. As a result, Synapse servers cannot send valid initial sync requests to any user that is a member of any one room where an unsanitized invalid user ID has sent at least one state event.Given that an outright majority of users resides on Synapse and similar servers that permit unsanitized user IDs over federation, this pull request adapts by decoding events individually, and then filtering the ones that contain invalid contents.