Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport into 5.16] CI | Fixing deprecated linter #1471

Merged
merged 4 commits into from
Nov 3, 2024

Conversation

liranmauda
Copy link
Contributor

Explain the changes

  1. [Backport into 5.16] CI | Fixing deprecated linter

liranmauda and others added 4 commits November 3, 2024 13:50
Fixing the CLI decision error handling to avoid lint errors

Signed-off-by: liranmauda <[email protected]>
(cherry picked from commit 10d81d1)
- Using `golangci-lint` for lint in the Makefile target
- Adding `.golangci.yml` as a configuration file
- Fixing some lint errors

Signed-off-by: liranmauda <[email protected]>
(cherry picked from commit 496b2dd)
Signed-off-by: Kaustav Majumder <[email protected]>
(cherry picked from commit 11392ab)
Removing golangci-lint-action in favor or make lint

Signed-off-by: liranmauda <[email protected]>
(cherry picked from commit 88564d2)
@liranmauda liranmauda merged commit 6ec1073 into noobaa:5.16 Nov 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants