Addition of Telemeter metrics #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimrod-becker
approved these changes
Jul 18, 2019
jeniawhite
force-pushed
the
evgb-Telemetry
branch
2 times, most recently
from
357262c
to
e20bd35
Compare
shtripat
reviewed
Jul 18, 2019
| @@ -7,7 +7,7 @@ | |||
| { | |||
| alert: 'NooBaaSystemCapacityWarning85', | |||
| expr: ||| | |||
| NooBaa_system_capacity{} > 85 | |||
| NooBaa_system_capacity > 85 | |||
There was a problem hiding this comment.
Don't we have some label selectors for metrics? Any unique identifier for cluster?
There was a problem hiding this comment.
Have not been implemented yet.
I've opened an issue with a feature enhancement: #12
Feel free to update with additional information and exact examples that will help us to improve our metrics.
Thank you.
jeniawhite
force-pushed
the
evgb-Telemetry
branch
from
e20bd35
to
7fa7691
Compare
|
I see that few recording rules were added. But I don't see anything here: |
|
@umangachapagain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the rules for the telemeter project.