Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC | GPFS | Threaded Multiple Object Delete fix #8388

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Sep 19, 2024

Explain the changes

  1. When calling delete multiple objects on the same key & version concurrently, the version might move/delete, on GPFS we saw that _open_files_gpfs() failed on ENOENT in that case, therefore added a retry when got ENOENT, next iteration we will return if the version was deleted or get the new location of the version.

Issues: Fixed #xxx / Gap #xxx

  1. Fixed NSFS | S3 | Versioning: Threaded delete of multiple objects does not delete #8377
  2. Gap - Enable s3tests_boto3/functional/test_s3.py::test_versioning_concurrent_multi_object_delete, currently it's not working because they call put bucket twice and the test fails on BucketAlreadyExists, the test I added dooes the same as the ceph test but in general we want to remove it from the pending list. Opened a bug - test_versioning_concurrent_multi_object_delete creates the bucket twice and fails on BucketAlreadyExists ceph/s3-tests#588.

Testing Instructions:

  1. Run sudo jest -t 'concurrent multi object delete' on GPFS cluster or run s3tests_boto3/functional/test_s3.py::test_versioning_concurrent_multi_object_delete while fixing manually the bug on s3-tests code - see the suggested fix in test_versioning_concurrent_multi_object_delete creates the bucket twice and fails on BucketAlreadyExists ceph/s3-tests#588.
  • Doc added/updated
  • Tests added

@romayalon romayalon force-pushed the romy-threaded-multi-object-delete branch from 16cd2e8 to b4b2968 Compare September 19, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NSFS | S3 | Versioning: Threaded delete of multiple objects does not delete
1 participant