Added a fix for prometheusDuplicateTimestamp error #8370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achouhan09
requested review from
liranmauda,
romayalon,
naveenpaul1,
a team and
jackyalbo
and removed request for
a team
achouhan09
force-pushed
the
prometheus_fix
branch
2 times, most recently
from
5f4283f
to
d981b82
Compare
achouhan09
force-pushed
the
prometheus_fix
branch
from
d981b82
to
3145ff3
Compare
achouhan09
force-pushed
the
prometheus_fix
branch
from
3145ff3
to
77f5260
Compare
…or nodejs Signed-off-by: Aayush Chouhan <[email protected]>
achouhan09
force-pushed
the
prometheus_fix
branch
from
77f5260
to
ca82443
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
PrometheusDuplicateTimestampsis a type of warning or error in Prometheus indicating that multiple samples with the same timestamp but different values were encountered.The
nodejsreport was generating default metrics that were overlapping with those from thecorereport. This overlap led to metrics with identical timestamps but different values being ingested by Prometheus, causing the warnings.Solution: We are creating a new registry for collecting all the default metrics for nodejs.
Read About prom-client
Before changes:
After fixes:
Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
kubectl exec -it noobaa-core-0 -- curl localhost:8080/metrics/web_server | grep NooBaa_odf_health_status