Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | Regular object key & dir content object overriding #8348

Closed
wants to merge 1 commit into from

Conversation

naveenpaul1
Copy link
Contributor

@naveenpaul1 naveenpaul1 commented Sep 11, 2024

Explain the changes

  1. PR will handle Key and Key/ overriding, object obj1 overriding with obj1/ should not fail and vice versa
  • unlink the file obj1 when try to override with dir obj1/ to avoid Not a directory error
  • delete the folder obj1/ when try to override with file obj1 to avoid error InternalError
    normal override(object1 overrides object1 or dir1/ overrides dir1/) will not delete the file/folder

Issues: Fixed #xxx / Gap #xxx

  1. NSFS | Regular object key & dir content object - key/ co-existence and overriding #8320

Testing Instructions:

  1. Please refer test in issue NSFS | Regular object key & dir content object - key/ co-existence and overriding #8320
  2. when obj1 override with obj1/ dir, a new folder should be created with the name obj1/
  3. when obj1/ dir override with key obj1, a new file should be created with the name obj1
  4. object1 overrides object1 and dir1/ overrides dir1/ should not delete the respective file/folder
  • Doc added/updated
  • Tests added

@naveenpaul1 naveenpaul1 force-pushed the object_override branch 2 times, most recently from 30ac0f3 to 99e3689 Compare September 11, 2024 14:36
@pull-request-size pull-request-size bot added size/L and removed size/S labels Sep 11, 2024
@naveenpaul1 naveenpaul1 marked this pull request as ready for review September 11, 2024 14:58
@naveenpaul1
Copy link
Contributor Author

These changes wont work with versioning, Need to update the code once versioning changes are merged. PR Blocked

@naveenpaul1 naveenpaul1 marked this pull request as draft September 20, 2024 05:28
@naveenpaul1 naveenpaul1 closed this by deleting the head repository Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant