NSFS : S3 rm with --recursive option does not delete all the objects #8317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveenpaul1
force-pushed
the
object_delete_issue
branch
from
fa2ec76
to
bfd80fc
Compare
naveenpaul1
force-pushed
the
object_delete_issue
branch
2 times, most recently
from
bc10334
to
4e5d502
Compare
naveenpaul1
requested review from
romayalon and
guymguym
and removed request for
romayalon
romayalon
requested changes
Sep 3, 2024
| // dir_key and marker_dir comparison will fail when there are folder with structure slimier to | ||
| // "dir_prfix.12345/" and "dir_prfix.12345.old/" because "/" considered greater than "." to fix this | ||
| // all the backslash is replaced with space. This updated marker and dir_key used only for comparison. | ||
| const updated_marker_dir = marker_dir.replaceAll('/', ' '); |
There was a problem hiding this comment.
I think that instead of replacing the value of / we need to have a better comparison function, instead of comparing dir_key < marker_dir and so on, we will call that comparison function. WDYT?
| @@ -258,6 +258,11 @@ function get_entry_name(e) { | |||
| return e.name; | |||
| } | |||
|
|
|||
| function get_entry_for_sorting(e) { | |||
| const check = e.key.includes('.') ? e.key.slice(e.key.indexOf(".")).includes('/') : false; | |||
There was a problem hiding this comment.
is '.' the only special char that causing this issue?
|
PR : 8324 have few overlapping changes, Will update this PR once 8324 is merged, |
Signed-off-by: naveenpaul1 <[email protected]>
naveenpaul1
force-pushed
the
object_delete_issue
branch
from
4e5d502
to
2063d39
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Dir structure like this is will fail
Issues: Fixed #xxx / Gap #xxx
#8197
Testing Instructions: